Re: [Pingus-CVS] CVS: Games/Pingus/src/worldobjs liquid.cxx,1.2,1.3

[Ingo Ruhnke]

David Philippi <address@hidden> writes:

>> Same here, 'recycling' a variable, which had a completly different
>> meaning a few lines before will not do any good, give one of them a
>> different name.
> 
> What's the problem with recycling a variable? As long as it's not used with 
> the former data in any case later on I can't see any problems with this.

A variable should have a single well defined purpose, not change its
purpose suddenly half the way down. Variables are not an expensive
resoure which needs to get recycled, so we shouldn't do that.

-- 
WWW:      http://pingus.seul.org/~grumbel/ 
Games:    http://pingus.seul.org/~grumbel/gamedesigns/
JabberID: address@hidden 
ICQ:      59461927