[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v3 09/12] tests/libqos/pci: Clean u
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v3 09/12] tests/libqos/pci: Clean up string interpolation into QMP input |
Date: |
Fri, 28 Jul 2017 14:05:38 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Jul 25, 2017 at 04:15:20PM -0500, Eric Blake wrote:
> @@ -419,19 +420,18 @@ static void test_ivshmem_server_irq(void)
> static void test_ivshmem_hotplug(void)
> {
> const char *arch = qtest_get_arch();
> - gchar *opts;
> + QObject *extra_args = qobject_from_jsonf("{ 'shm': '%s', 'size': '1M' }",
> + tmpshm);
Is there a difference between:
qobject_from_jsonf("{ 'shm': '%s' }", tmpshm);
and:
qobject_from_jsonf("{ 'shm': %s }", tmpshm);
?
Below you use %s instead of '%s'.
signature.asc
Description: PGP signature