|
From: | Markus Armbruster |
Subject: | Re: [Qemu-block] [Qemu-devel] [PATCH v3 09/12] tests/libqos/pci: Clean up string interpolation into QMP input |
Date: | Mon, 31 Jul 2017 09:29:35 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Eric Blake <address@hidden> writes: > On 07/28/2017 11:35 AM, Eric Blake wrote: >>>> + QObject *extra_args = qobject_from_jsonf("{ 'shm': '%s', 'size': '1M' >>>> }", >>>> + tmpshm); >>> > >> Passing '%s' through qobject_from_jsonf() is generally wrong (it would >> produce ''...'' instead of the intended '...'). >> >> Looks like something to fix on the next round. >> > > What's scary is that the testsuite didn't start failing. That's not > good; we'll want to figure out why the bug didn't impact the test. Good idea.
[Prev in Thread] | Current Thread | [Next in Thread] |