[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v3 09/12] tests/libqos/pci: Clean u
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v3 09/12] tests/libqos/pci: Clean up string interpolation into QMP input |
Date: |
Fri, 28 Jul 2017 11:37:25 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/28/2017 11:35 AM, Eric Blake wrote:
>>> + QObject *extra_args = qobject_from_jsonf("{ 'shm': '%s', 'size': '1M'
>>> }",
>>> + tmpshm);
>>
> Passing '%s' through qobject_from_jsonf() is generally wrong (it would
> produce ''...'' instead of the intended '...').
>
> Looks like something to fix on the next round.
>
What's scary is that the testsuite didn't start failing. That's not
good; we'll want to figure out why the bug didn't impact the test.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature