[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Updated BGR vs. RGB vga patch...

From: Leonardo E. Reiter
Subject: Re: [Qemu-devel] Updated BGR vs. RGB vga patch...
Date: Mon, 10 Apr 2006 14:24:30 -0400
User-agent: Mozilla Thunderbird 1.0.7 (X11/20051013)

Here's a better patch... I can't seem to validate BGR X servers in 15 or 16-bit mode. This may not make sense (or be prevalent) on little-endian machines anyway (I'm using VNC server on a little endian box to test against.) In any case, 24 and 32-bit works like a charm. I use the same basic logic as the original patch, so it's possible it was always broken for 16-bit... especially given that most Sun X servers run in 24-bit, which is what the originators intended the patch for.

Anyway, I didn't spend time figuring out how to query SDL for the ordering. You still have to manually pass in -bgr. The good news is that all the computation is now done at compile-time, with only very few tests done at run-time. I agree with your assessment of compile-time versus run-time options... I was merely suggesting a compromise to fend off the minor performance hit of using the old patch. But the method you suggested is much better and that's how it's implemented now.


Leo Reiter

Paul Brook wrote:
Ok. For the record I also think it's a bad idea to have features conditionally compiled. Either something is worth including, or we have to ask whether there's any point having it in qemu at all. The exception being debug code, which probably isn't useful unless you're already building qemu from source.


Leonardo E. Reiter
Vice President of Product Development, CTO

Win4Lin, Inc.
Virtual Computing from Desktop to Data Center
Main: +1 512 339 7979
Fax: +1 512 532 6501

reply via email to

[Prev in Thread] Current Thread [Next in Thread]