[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec

From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec
Date: Tue, 27 May 2008 16:33:50 +0100
User-agent: KMail/1.9.9

> +void cpu_load_flags(CPUState *env);
> +void cpu_put_flags(CPUState *env);

These really need a comment saying what they do. The names are not at all 
intuitive. Also, why load/put? I'd expect load/save/store or get/put.

> +#if defined(reg_REGWPTR)
> +static uint32_t *saved_regwptr;
> +#endif

Eww. You've replaced reasonably self contained local code with a global 
variable hidden deep in target specific code. I plan on adding multithreaded 
qemu support soon, so this is a non-starter.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]