[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too.
From: |
Glauber Costa |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too. |
Date: |
Tue, 27 May 2008 13:25:05 -0300 |
On Tue, May 27, 2008 at 12:34 PM, Fabrice Bellard <address@hidden> wrote:
> Glauber Costa wrote:
>>
>> Unlike other architectures, i386 lacked a "halted" attribute, going
>> with a flag into hflags. By using the halted attribute, we can make
>> the code look like more other architectures, and simplify the code in
>> some instances. In this commit, we make the code for info_cpus simpler
>> in monitor.c
>
> Good for the I386 halted attribute, as it was a mistake to put in in the
> hflags. For the memory, hflags should contain only parts of the CPU state
> known at translation time and should be equal to tb->flags. Most CPUs
> (including x86 !) do not follow this sane rule.
What about HF_GIF_MASK? It looks like another case of something that
is mistakenly put into hflags. What do you say?
> For cpu_info_ip, it would be simpler to return an uint64_t containing the
> PC. I don't think the sparc case with npc really matters.
>
> Fabrice.
>
>
>
>
--
Glauber Costa.
"Free as in Freedom"
http://glommer.net
"The less confident you are, the more serious you have to act."
- [Qemu-devel] [PATCH 6/6] cpu-exec-dump, (continued)
- Re: [Qemu-devel] [PATCH 5/6] isolate mmu code in arch-specific function, Fabrice Bellard, 2008/05/27
- Re: [Qemu-devel] [PATCH 5/6] isolate mmu code in arch-specific function, Glauber Costa, 2008/05/27
- Re: [Qemu-devel] [PATCH 5/6] isolate mmu code in arch-specific function, Paul Brook, 2008/05/27
- Re: [Qemu-devel] [PATCH 4/6] simply cpu_exec further, Blue Swirl, 2008/05/27
- Re: [Qemu-devel] [PATCH 4/6] simply cpu_exec further, Glauber Costa, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Fabrice Bellard, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Blue Swirl, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Glauber Costa, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too.,
Glauber Costa <=
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Fabrice Bellard, 2008/05/27
- Re: [Qemu-devel] [PATCH 2/6] Push common interrupt variables to cpu-defs.h, Fabrice Bellard, 2008/05/27
Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec, Paul Brook, 2008/05/27
Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec, Fabrice Bellard, 2008/05/27