[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] simply cpu_exec further
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] simply cpu_exec further |
Date: |
Tue, 27 May 2008 19:18:13 +0300 |
On 5/27/08, Glauber Costa <address@hidden> wrote:
> We change interrupt functions so they have the same
> signature, getting only an env parameter. When necessary,
> some more attributed were added to the relevant CPUState to
> make it possible.
> +void arch_handle_interrupt_request(CPUState *env);
I'd use cpu_handle_interrupt_request().
> --- a/target-sparc/op_helper.c
> +++ b/target-sparc/op_helper.c
> @@ -2689,8 +2689,9 @@ static const char * const excp_names[0x50] = {
> };
> #endif
>
> -void do_interrupt(int intno)
> +void do_interrupt(CPUState *cpu)
env1 would be better.
> {
> + int intno = cpu->exception_index;
> #ifdef DEBUG_PCALL
> if (loglevel & CPU_LOG_INT) {
> static int count;
> @@ -2803,9 +2804,10 @@ static const char * const excp_names[0x80] = {
> };
> #endif
>
> -void do_interrupt(int intno)
> +void do_interrupt(CPUState *env)
Same here. Otherwise you shadow the AREG0 env.
> +void arch_handle_interrupt_request(CPUState *env)
And here.
I think this function and do_interrupt should belong to helper.c, they
are not called from ops. I'll do some rearranging. After that my env
comment does not matter.
- [Qemu-devel] [PATCH 1/6] simplify cpu_exec, (continued)
- [Qemu-devel] [PATCH 1/6] simplify cpu_exec, Glauber Costa, 2008/05/27
- [Qemu-devel] [PATCH 2/6] Push common interrupt variables to cpu-defs.h, Glauber Costa, 2008/05/27
- [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Glauber Costa, 2008/05/27
- [Qemu-devel] [PATCH 4/6] simply cpu_exec further, Glauber Costa, 2008/05/27
- [Qemu-devel] [PATCH 5/6] isolate mmu code in arch-specific function, Glauber Costa, 2008/05/27
- [Qemu-devel] [PATCH 6/6] cpu-exec-dump, Glauber Costa, 2008/05/27
- Re: [Qemu-devel] [PATCH 6/6] cpu-exec-dump, Paul Brook, 2008/05/27
- Re: [Qemu-devel] [PATCH 5/6] isolate mmu code in arch-specific function, Fabrice Bellard, 2008/05/27
- Re: [Qemu-devel] [PATCH 5/6] isolate mmu code in arch-specific function, Glauber Costa, 2008/05/27
- Re: [Qemu-devel] [PATCH 5/6] isolate mmu code in arch-specific function, Paul Brook, 2008/05/27
- Re: [Qemu-devel] [PATCH 4/6] simply cpu_exec further,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH 4/6] simply cpu_exec further, Glauber Costa, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Fabrice Bellard, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Blue Swirl, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Glauber Costa, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Glauber Costa, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Fabrice Bellard, 2008/05/27
- Re: [Qemu-devel] [PATCH 2/6] Push common interrupt variables to cpu-defs.h, Fabrice Bellard, 2008/05/27
Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec, Paul Brook, 2008/05/27
Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec, Fabrice Bellard, 2008/05/27