Re: [Qemu-devel] [RFC, PATCH] Host AIO support detection, OpenBSD host support

[Todd T. Fries]

I am responsible for that.  Back when the qemu siginfo stuff was in use
it was necessary.

Sorry for the extra cruft, will look for cleaning it when qemu releases
next..

Looking forward to the next release with OpenBSD/sparc running inside
qemu ;-)

Thanks,
-- 
Todd Fries .. address@hidden

 _____________________________________________
|                                             \  1.636.410.0632 (voice)
| Free Daemon Consulting, LLC                 \  1.405.227.9094 (voice)
| http://FreeDaemonConsulting.com             \  1.866.792.3418 (FAX)
| "..in support of free software solutions."  \          250797 (FWD)
|                                             \
 \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\
                                                 
              37E7 D3EB 74D0 8D66 A68D  B866 0326 204E 3F42 004A
                        http://todd.fries.net/pgp.txt

Penned by Anthony Liguori on 20080812 14:46.53, we have:
> Blue Swirl wrote:
>> Here are two patches, loosely based on patches in OpenBSD ports system
>> that enable compiling Qemu. The first patch makes AIO use conditional
>> on host AIO support. The second one adjusts various include files etc.
>>
>> I'd like to commit both of these, is that OK?
>>   
>
> The first patch is fine but the second patch has some bogus things in  
> it.  For instance:
>>
>> Index: qemu/configure
>> ===================================================================
>> --- qemu.orig/configure    2008-08-12 17:12:15.000000000 +0000
>> +++ qemu/configure    2008-08-12 17:33:36.000000000 +0000
>> @@ -150,6 +150,7 @@
>> @@ -1076,6 +1081,14 @@
>>      echo "#define HAVE_BYTESWAP_H 1" >> $config_h
>>    fi
>>  fi
>> +
>> +if [ "$openbsd" = "yes" ] ; then
>> +  echo "#define ENOTSUP 4096" >> $config_h
>> +  echo "#define qemu_siginfo siginfo_t" >> $config_h
>> +else
>> +  echo "#define qemu_siginfo struct siginfo" >> $config_h
>> +fi
>
> But qemu_siginfo isn't actually used anywhere.  That's just one example,  
> the patch seems to have a lot of things like this in it.
>
> Regards,
>
> Anthony Liguori
>
>