[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] Use libuuid if available.
From: |
Gleb Natapov |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] Use libuuid if available. |
Date: |
Mon, 25 Aug 2008 12:44:57 +0300 |
On Sun, Aug 24, 2008 at 08:50:42PM +0300, Blue Swirl wrote:
> On 8/24/08, Gleb Natapov <address@hidden> wrote:
> > +# uuid library
> > +if test "$uuid" = "yes" ; then
> > + `pkg-config uuid 2> /dev/null` || uuid="no"
> > +fi
>
> Please implement the probe like ncurses one.
>
> > +static int uuid_dont_generate;
>
> Positive logic would be clearer: generate_uuid = 1;
>
> > +#ifdef CONFIG_UUID
> > + uuid_dont_generate = 1;
>
> generate_uuid = 0;
>
> > + if (!uuid_dont_generate)
> > + uuid_generate(qemu_uuid);
>
> if (generate_uuid)
>
Done.
--
Gleb.
- [Qemu-devel] [PATCH 0/6] Add UUID command-line option, Gleb Natapov, 2008/08/24
- [Qemu-devel] [PATCH 1/6] Use IO port for qemu<->guest BIOS communication., Gleb Natapov, 2008/08/24
- [Qemu-devel] [PATCH 2/6] Add -uuid command line option., Gleb Natapov, 2008/08/24
- [Qemu-devel] [PATCH 3/6] Add "info uuid" command to monitor., Gleb Natapov, 2008/08/24
- [Qemu-devel] [PATCH 4/6] Use libuuid if available., Gleb Natapov, 2008/08/24
- [Qemu-devel] [PATCH 5/6] Add UUID to BIOS configuration info., Gleb Natapov, 2008/08/24
- [Qemu-devel] [PATCH 6/6] Pass cpu speed into SM BIOS., Gleb Natapov, 2008/08/24
- Re: [Qemu-devel] [PATCH 0/6] Add UUID command-line option, Blue Swirl, 2008/08/24