[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1/2] qemu/qdev: type safety in reset handler
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 1/2] qemu/qdev: type safety in reset handler |
Date: |
Wed, 16 Sep 2009 13:06:13 +0300 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Wed, Sep 16, 2009 at 12:05:41PM +0200, Gerd Hoffmann wrote:
> Hi,
>
>>> Otherwise, I prefer the old version. We test if there exist
>>> dev->info->reset
>>> and just after that, we use
>>> dev->info->reset()
>>
>> Good point. I think I'll just move the if (dev->info->reset)
>> into qdev_reset.
>
> How about going one step further? Register *one* qdev_reset instance
> which then walks the qdev tree and calls ->reset() for every device?
Will be much more code. Why not reuse the existing queue?
> cheers,
> Gerd
Message not available