[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 1/2] qemu/qdev: type safety in reset handler

From: Michael S. Tsirkin
Subject: [Qemu-devel] Re: [PATCH 1/2] qemu/qdev: type safety in reset handler
Date: Wed, 16 Sep 2009 13:30:51 +0300
User-agent: Mutt/1.5.19 (2009-01-05)

On Wed, Sep 16, 2009 at 12:22:28PM +0200, Gerd Hoffmann wrote:
> On 09/16/09 12:06, Michael S. Tsirkin wrote:
>>> How about going one step further?  Register *one* qdev_reset instance
>>> which then walks the qdev tree and calls ->reset() for every device?
>> Will be much more code. Why not reuse the existing queue?
> I think we'll need such a tree walker anyway sooner or later.  Thus  
> you'll get bonus points for making it generic, so it could be used for a  
> -- say -- late_init() callback too.
> Also the reset() callbacks order will be based on the position of the  
> device in the tree instead of being more or less random.
> cheers,
>   Gerd

Better make it a separate patch, later.
For now, I'm just addressing the type safety.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]