[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatt

From: Anthony Liguori
Subject: Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting)
Date: Thu, 03 May 2012 19:41:33 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 05/03/2012 02:58 PM, Peter Maydell wrote:
On 9 February 2012 13:46, Anthony Liguori<address@hidden>  wrote:
On 02/09/2012 03:48 AM, Markus Armbruster wrote:
You buried the one truly important sentence, let me dig it out for you:

         *** Patches should always go to the mailing list ***

Exceptions need justification.  Responsible handling embargoed security
issues may qualify.  Style fixes certainly not.

100% agreed.

I don't see anything in the mailing list archives corresponding
to commits f05ae537, f6af014e.

No unreviewed patches should go double when we're in hardfreeze!

These patches are admittedly trivial but it is important to stress the point that all patches need to go on the mailing list before being committed.

It's an important part of keeping the development process inclusive. I don't think it's reasonable to ask for an Acked-by on something as simple as indentation changes but at the same time, there's no reason not to just post patches.


Anthony Liguori

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]