qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/39] memory: cpu_physical_memory_set_dirty_ran


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 11/39] memory: cpu_physical_memory_set_dirty_range() allways dirty all flags
Date: Wed, 06 Nov 2013 16:15:53 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

On 11/06/2013 06:04 AM, Juan Quintela wrote:

s/allways dirty/always dirties/ in the subject

> So remove the flag argument and do it directly.  After this change, there is 
> nothing else using cpu_physical_memory_set_dirty_flags() so remove it.

Any reason you didn't line wrap the commit message?

> 
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  exec.c                         |  2 +-
>  include/exec/memory-internal.h | 11 ++---------
>  memory.c                       |  2 +-
>  3 files changed, 4 insertions(+), 11 deletions(-)

But the code itself is correct.  For 9 through 11:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]