[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/39] memory: cpu_physical_memory_set_dirty_ran
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 11/39] memory: cpu_physical_memory_set_dirty_range() allways dirty all flags |
Date: |
Wed, 06 Nov 2013 16:15:53 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/06/2013 06:04 AM, Juan Quintela wrote:
s/allways dirty/always dirties/ in the subject
> So remove the flag argument and do it directly. After this change, there is
> nothing else using cpu_physical_memory_set_dirty_flags() so remove it.
Any reason you didn't line wrap the commit message?
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> exec.c | 2 +-
> include/exec/memory-internal.h | 11 ++---------
> memory.c | 2 +-
> 3 files changed, 4 insertions(+), 11 deletions(-)
But the code itself is correct. For 9 through 11:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 03/39] memory: cpu_physical_memory_set_dirty_range() return void, (continued)
- [Qemu-devel] [PATCH 06/39] exec: create function to get a single dirty bit, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 08/39] exec: simplify notdirty_mem_write(), Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 05/39] memory: create function to set a single dirty bit, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 07/39] memory: make cpu_physical_memory_is_dirty return bool, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 10/39] memory: set single dirty flags when possible, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 11/39] memory: cpu_physical_memory_set_dirty_range() allways dirty all flags, Juan Quintela, 2013/11/06
- Re: [Qemu-devel] [PATCH 11/39] memory: cpu_physical_memory_set_dirty_range() allways dirty all flags,
Eric Blake <=
- [Qemu-devel] [PATCH 09/39] memory: all users of cpu_physical_memory_get_dirty used only one flag, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 12/39] memory: cpu_physical_memory_mask_dirty_range() always clear a single flag, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 13/39] memory: use DIRTY_MEMORY_* instead of *_DIRTY_FLAG, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 14/39] memory: use bit 2 for migration, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 15/39] memory: make sure that client is always inside range, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 16/39] memory: only resize dirty bitmap when memory size increases, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 17/39] memory: cpu_physical_memory_clear_dirty_flag() result is never used, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 18/39] bitmap: Add bitmap_zero_extend operation, Juan Quintela, 2013/11/06