[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/8] migration: new migration test mode
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 7/8] migration: new migration test mode |
Date: |
Wed, 7 Oct 2015 09:08:29 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/07/2015 07:56 AM, Dr. David Alan Gilbert wrote:
> * Denis V. Lunev (address@hidden) wrote:
>> From: Igor Redko <address@hidden>
>>
>> In this patch the ability to start a migration with test-only
>> capability was added. It allows to gather the guest VM’s memory
>> usage statistics avoiding time and memory overheads and real
>> data transmission. New MIGRATION_STATUS_TEST_COMPLETED was
>> added to distinguish between test migration and true migration
>> success states.
>
> Why isn't this just a new transport? i.e. I could do this just by doing
> a migrate to test: ?
>
> It seems simpler and avoids some of the special casing?
Indeed. Even if the new state can only be triggered by using a new
option, the fact that the new state exists in introspection means
clients have to figure out what to do with it; while a new transport
would not require any new states ("running" to completion means that
nothing migrated, but the existing states can then be reused to see that
the test: transport has finished computing its numbers).
>> +++ b/qapi-schema.json
>> @@ -432,6 +432,8 @@
>> #
>> # @completed: migration is finished.
>> #
>> +# @test-completed: migration time estimation finished.
>> +#
If this gets added, in spite of our ideas to use a 'test:' transport
instead of a new state, it would need a 'since 2.5' marker.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] Debugging Migration, (continued)
- Re: [Qemu-devel] Debugging Migration, Denis V. Lunev, 2015/10/08
- Re: [Qemu-devel] Debugging Migration, John Snow, 2015/10/08
- Re: [Qemu-devel] Debugging Migration, Denis V. Lunev, 2015/10/08
- [Qemu-devel] [RFC 0/8] QEMUFile-way to gather VM's memory statistics, Denis V. Lunev, 2015/10/08
- [Qemu-devel] [PATCH 3/8] migration: add new capability test-only, Denis V. Lunev, 2015/10/08
- Re: [Qemu-devel] [PATCH 3/8] migration: add new capability test-only, Eric Blake, 2015/10/08
- Re: [Qemu-devel] [PATCH 3/8] migration: add new capability test-only, Denis V. Lunev, 2015/10/09
- Re: [Qemu-devel] [PATCH 3/8] migration: add new capability test-only, Dr. David Alan Gilbert, 2015/10/09
- [Qemu-devel] [PATCH 7/8] migration: new migration test mode, Denis V. Lunev, 2015/10/08
- Re: [Qemu-devel] [PATCH 7/8] migration: new migration test mode, Dr. David Alan Gilbert, 2015/10/08
- Re: [Qemu-devel] [PATCH 7/8] migration: new migration test mode,
Eric Blake <=
- Re: [Qemu-devel] [PATCH 7/8] migration: new migration test mode, Denis V. Lunev, 2015/10/09
- Re: [Qemu-devel] [PATCH 7/8] migration: new migration test mode, Dr. David Alan Gilbert, 2015/10/08
- Re: [Qemu-devel] [PATCH 7/8] migration: new migration test mode, Denis V. Lunev, 2015/10/09
- Re: [Qemu-devel] [PATCH 7/8] migration: new migration test mode, Dr. David Alan Gilbert, 2015/10/08
- [Qemu-devel] [PATCH 4/8] migration: add function for reseting migration bitmap, Denis V. Lunev, 2015/10/08
- [Qemu-devel] [PATCH 5/8] migration: add draft of new transport, Denis V. Lunev, 2015/10/08
- [Qemu-devel] [PATCH 2/8] qemu-file: new hook in qemu-file, Denis V. Lunev, 2015/10/08
- [Qemu-devel] [PATCH 6/8] migration: implementation of hook_ram_sync, Denis V. Lunev, 2015/10/08
- Re: [Qemu-devel] [PATCH 6/8] migration: implementation of hook_ram_sync, Paolo Bonzini, 2015/10/08
- Re: [Qemu-devel] [PATCH 6/8] migration: implementation of hook_ram_sync, Denis V. Lunev, 2015/10/09