[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 6/6] Convert error_report*_err() to warn_repo
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v1 6/6] Convert error_report*_err() to warn_report*_err() |
Date: |
Fri, 7 Jul 2017 09:07:13 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, Jul 06, 2017 at 04:49:54PM -0700, Alistair Francis wrote:
> Convert all uses of error_report*_err("[Ww]arning:"... to use
> warn_report*_err() instead. This helps standardise on a single
> method of printing warnings to the user.
>
> Signed-off-by: Alistair Francis <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
> ---
>
> hw/core/qdev-properties.c | 2 +-
> hw/i386/pc.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
> index f5983c83da..3d0bba21a2 100644
> --- a/hw/core/qdev-properties.c
> +++ b/hw/core/qdev-properties.c
> @@ -1169,7 +1169,7 @@ static void qdev_prop_set_globals_for_type(DeviceState
> *dev,
> error_propagate(prop->errp, err);
> } else {
> assert(prop->user_provided);
> - error_reportf_err(err, "Warning: ");
> + warn_report_err(err);
> }
> }
> }
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 58f8a4f4a5..5c2cc3f836 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1320,8 +1320,7 @@ void pc_acpi_init(const char *default_dsdt)
>
> acpi_table_add_builtin(opts, &err);
> if (err) {
> - error_reportf_err(err, "WARNING: failed to load %s: ",
> - filename);
> + warn_reportf_err(err, "failed to load %s: ", filename);
> }
> g_free(filename);
> }
> --
> 2.11.0
>
--
Eduardo
- Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), (continued)
- Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Greg Kurz, 2017/07/07
- Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Cornelia Huck, 2017/07/07
- Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Eduardo Habkost, 2017/07/07
- Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Stefan Hajnoczi, 2017/07/07
- Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Markus Armbruster, 2017/07/07
- Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Marcel Apfelbaum, 2017/07/10
- [Qemu-devel] [PATCH v1 6/6] Convert error_report*_err() to warn_report*_err(), Alistair Francis, 2017/07/06
- [Qemu-devel] [PATCH v1 5/6] error: Implement the warn and free Error functions, Alistair Francis, 2017/07/06
- [Qemu-devel] [PATCH v1 4/6] char-socket: Report TCP socket waiting as information, Alistair Francis, 2017/07/06