Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

[Markus Armbruster]

Alistair Francis <address@hidden> writes:

> Convert all uses of error_report("[Ww]arning:"... to use warn_report()
> instead. This helps standardise on a single method of printing warnings
> to the user.
>
> All of the warnings were found using this regex expression:
>     error_report.*[Ww]arning:
> and replaced with:
>     warn_report("
>
> Signed-off-by: Alistair Francis <address@hidden>
> Suggested-by: Thomas Huth <address@hidden>

Doesn't compile.  Moreover, you obviously changed more than just lines
matching the regexp you quoted.

To ease review, I please split the patch as follows:

* First patch:

      sed -i 's/error_report("warning: \([^"]*"\)/warn_report("\1/i' ...

  plus indentation fixups.  Put exact sed command (or whatever else you
  use) in the commit message.

* Second patch with additional conversions.

This way the bulk of the changes is mechanical, and the non-mechanical
changes don't get lost in the sea of mechanical ones.