[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v1 2/9] ui: fix crash with sendkey and raw key numbe
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] [PATCH v1 2/9] ui: fix crash with sendkey and raw key numbers |
Date: |
Thu, 19 Oct 2017 15:28:41 +0100 |
Previously we enforced that all key events are using QKeyCodes
at time they are sent:
commit af07e5ff02ae6d4258fc5331007811d0b1c4d35a
Author: Daniel P. Berrange <address@hidden>
Date: Fri Sep 29 11:12:00 2017 +0100
ui: convert key events to QKeyCodes immediately
This commit forget to fix the code for the legacy 'sendkey'
command which still accepts key numbers from the user, which
then need converting to QKeyCodes
Signed-off-by: Daniel P. Berrange <address@hidden>
---
ui/input-legacy.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/ui/input-legacy.c b/ui/input-legacy.c
index 6bc3525499..c75aba1549 100644
--- a/ui/input-legacy.c
+++ b/ui/input-legacy.c
@@ -76,6 +76,11 @@ static KeyValue *copy_key_value(KeyValue *src)
{
KeyValue *dst = g_new(KeyValue, 1);
memcpy(dst, src, sizeof(*src));
+ if (dst->type == KEY_VALUE_KIND_NUMBER) {
+ QKeyCode code = qemu_input_key_number_to_qcode(dst->u.number.data);
+ dst->type = KEY_VALUE_KIND_QCODE;
+ dst->u.qcode.data = code;
+ }
return dst;
}
--
2.13.6
- [Qemu-devel] [PATCH v1 0/9] Various fixes for input/ps2 handling, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 2/9] ui: fix crash with sendkey and raw key numbers,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v1 3/9] ui: use correct union field for key number, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 1/9] input: use hex in ps2 keycode trace events, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 4/9] ps2: fix scancodes sent for Alt-Print key combination (aka SysRq), Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 5/9] ps2: fix scancodes sent for Shift/Ctrl+Print key combination, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 6/9] ps2: fix scancodess sent for Pause key in AT set 1, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 7/9] ps2: fix scancodes sent for Ctrl+Pause key combination, Daniel P. Berrange, 2017/10/19