[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 3/9] ui: use correct union field for key numb
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v1 3/9] ui: use correct union field for key number |
Date: |
Thu, 19 Oct 2017 10:19:01 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/19/2017 09:28 AM, Daniel P. Berrange wrote:
> The code converting key numbers to QKeyCode in the 'input-send-event'
> command mistakenly accessed the key->u.qcode union field instead of
> the key->u.number field. This is harmless because the fields use the
> same size datatype in both cases, but none the less it should be fixed
> to avoid confusion.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> ui/input.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/ui/input.c b/ui/input.c
> index 290b47354a..4e821f8f2b 100644
> --- a/ui/input.c
> +++ b/ui/input.c
> @@ -162,7 +162,7 @@ void qmp_input_send_event(bool has_device, const char
> *device,
> if (evt->type == INPUT_EVENT_KIND_KEY &&
> evt->u.key.data->key->type == KEY_VALUE_KIND_NUMBER) {
> KeyValue *key = evt->u.key.data->key;
> - QKeyCode code =
> qemu_input_key_number_to_qcode(key->u.qcode.data);
> + QKeyCode code =
> qemu_input_key_number_to_qcode(key->u.number.data);
> qemu_input_event_send_key_qcode(con, code,
> evt->u.key.data->down);
> } else {
> qemu_input_event_send(con, evt);
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v1 0/9] Various fixes for input/ps2 handling, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 2/9] ui: fix crash with sendkey and raw key numbers, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 3/9] ui: use correct union field for key number, Daniel P. Berrange, 2017/10/19
- Re: [Qemu-devel] [PATCH v1 3/9] ui: use correct union field for key number,
Eric Blake <=
- [Qemu-devel] [PATCH v1 1/9] input: use hex in ps2 keycode trace events, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 4/9] ps2: fix scancodes sent for Alt-Print key combination (aka SysRq), Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 5/9] ps2: fix scancodes sent for Shift/Ctrl+Print key combination, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 6/9] ps2: fix scancodess sent for Pause key in AT set 1, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 7/9] ps2: fix scancodes sent for Ctrl+Pause key combination, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 8/9] ui: normalize the 'sysrq' key into the 'print' key, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 9/9] ui: pull in latest keycodemapdb, Daniel P. Berrange, 2017/10/19