[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/9] input: use hex in ps2 keycode trace even
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/9] input: use hex in ps2 keycode trace events |
Date: |
Thu, 19 Oct 2017 10:17:30 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/19/2017 09:28 AM, Daniel P. Berrange wrote:
> Hardware scancodes are all documented in hex, so use that in trace
> events to make it easier to understand.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> hw/input/trace-events | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/hw/input/trace-events b/hw/input/trace-events
> index 6fcb3c063f..d04132d342 100644
> --- a/hw/input/trace-events
> +++ b/hw/input/trace-events
> @@ -1,7 +1,7 @@
> # See docs/devel/tracing.txt for syntax documentation.
>
> # hw/input/ps2.c
> -ps2_put_keycode(void *opaque, int keycode) "%p keycode %d"
> +ps2_put_keycode(void *opaque, int keycode) "%p keycode 0x%02x"
> ps2_read_data(void *opaque) "%p"
> ps2_set_ledstate(void *s, int ledstate) "%p ledstate %d"
> ps2_reset_keyboard(void *s) "%p"
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v1 0/9] Various fixes for input/ps2 handling, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 2/9] ui: fix crash with sendkey and raw key numbers, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 3/9] ui: use correct union field for key number, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 1/9] input: use hex in ps2 keycode trace events, Daniel P. Berrange, 2017/10/19
- Re: [Qemu-devel] [PATCH v1 1/9] input: use hex in ps2 keycode trace events,
Eric Blake <=
- [Qemu-devel] [PATCH v1 4/9] ps2: fix scancodes sent for Alt-Print key combination (aka SysRq), Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 5/9] ps2: fix scancodes sent for Shift/Ctrl+Print key combination, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 6/9] ps2: fix scancodess sent for Pause key in AT set 1, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 7/9] ps2: fix scancodes sent for Ctrl+Pause key combination, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 8/9] ui: normalize the 'sysrq' key into the 'print' key, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 9/9] ui: pull in latest keycodemapdb, Daniel P. Berrange, 2017/10/19