autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CVS autoconf + CVS automake = autoconf doesn't know its version


From: Raja R Harinath
Subject: Re: CVS autoconf + CVS automake = autoconf doesn't know its version
Date: 06 Apr 2001 12:17:47 -0500
User-agent: Gnus/5.090001 (Oort Gnus v0.01) Emacs/21.0.100

"Lars J. Aas" <address@hidden> writes:
> On Thu, Apr 05, 2001 at 05:36:48PM -0500, Raja R Harinath wrote:
> : The following patch fixes a problem with CVS autoconf, if a recent
> : enough CVS snapshot of automake was used on it.  
> 
> This is my proposal.  @PACKAGE doesn't seem to be needed.

@PACKAGE@ is needed.  It is used by Makefile.in for 'make dist'.

> Index: Makefile.am
> ===================================================================
> RCS file: /cvs/autoconf/Makefile.am,v
> retrieving revision 1.42
> diff -u -r1.42 Makefile.am
> --- Makefile.am       2001/03/27 12:02:16     1.42
> +++ Makefile.am       2001/04/06 11:05:17
> @@ -33,6 +33,7 @@
>  # FIXME: Current Automakes are blind and cannot see inner AC_SUBST,
>  # so help it.
>  PACKAGE_NAME = @PACKAGE_NAME@
> +VERSION = @VERSION@
>  
>  # FIXME:
>  # s/distpackageDATA/dist_pkgdata_DATA/

I feel this is the wrong place.  The locus of the problem is the
bypassing of 'aclocal' -- so 'aclocal.m4' is the best place to fix
it.  

Take a casual reader familiar with automake, and who doesn't remember
that 'aclocal' is bypassed.  The above line will look superfluous  --
after all, in every other package using automake, that line would be 
superfluous.  At a minimum, please place a comment on that line.

- Hari
-- 
Raja R Harinath ------------------------------ address@hidden
"When all else fails, read the instructions."      -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing."   -- Roy L Ash



reply via email to

[Prev in Thread] Current Thread [Next in Thread]