[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: CVS autoconf + CVS automake = autoconf doesn't know its version
From: |
Akim Demaille |
Subject: |
Re: CVS autoconf + CVS automake = autoconf doesn't know its version |
Date: |
10 Apr 2001 10:30:12 +0200 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Cuyahoga Valley) |
| On Fri, Apr 06, 2001 at 12:17:47PM -0500, Raja R Harinath wrote:
| : @PACKAGE@ is needed. It is used by Makefile.in for 'make dist'.
| :
| : "Lars J. Aas" <address@hidden> writes:
| : > Index: Makefile.am
| : > ===================================================================
| : > @@ -33,6 +33,7 @@
| : > # FIXME: Current Automakes are blind and cannot see inner AC_SUBST,
| : > # so help it.
| : > PACKAGE_NAME = @PACKAGE_NAME@
| : > +VERSION = @VERSION@
| :
| : I feel this is the wrong place. The locus of the problem is the
| : bypassing of 'aclocal' -- so 'aclocal.m4' is the best place to fix
| : it.
| :
| : Take a casual reader familiar with automake, and who doesn't remember
| : that 'aclocal' is bypassed. The above line will look superfluous --
| : after all, in every other package using automake, that line would be
| : superfluous. At a minimum, please place a comment on that line.
|
| I've attached the minimum solution below, which I think I can just apply
| without approval to get this fixed (it's really just a correction to the
| previous patch that was OK'd). I see your point, though, but want some
| other maintainer's opinion on it before moving the fix into aclocal.m4.
| I assume PACKAGE_NAME will be moved along with VERSION and PACKAGE?
| If I don't hear anything during the day, I'll just commit the below patch.
I prefer Raja's solution for the very reason he described. It's
really a problem between Automake and aclocal.m4, so it should be
fixed there, or in configure.in.