Re: CVS autoconf + CVS automake = autoconf doesn't know its version

[Lars J. Aas]

On Fri, Apr 06, 2001 at 12:17:47PM -0500, Raja R Harinath wrote:
: @PACKAGE@ is needed.  It is used by Makefile.in for 'make dist'.
:
: "Lars J. Aas" <address@hidden> writes:
: > Index: Makefile.am
: > ===================================================================
: > @@ -33,6 +33,7 @@
: >  # FIXME: Current Automakes are blind and cannot see inner AC_SUBST,
: >  # so help it.
: >  PACKAGE_NAME = @PACKAGE_NAME@
: > +VERSION = @VERSION@
: 
: I feel this is the wrong place.  The locus of the problem is the
: bypassing of 'aclocal' -- so 'aclocal.m4' is the best place to fix
: it.  
: 
: Take a casual reader familiar with automake, and who doesn't remember
: that 'aclocal' is bypassed.  The above line will look superfluous  --
: after all, in every other package using automake, that line would be 
: superfluous.  At a minimum, please place a comment on that line.

I've attached the minimum solution below, which I think I can just apply
without approval to get this fixed (it's really just a correction to the
previous patch that was OK'd).  I see your point, though, but want some
other maintainer's opinion on it before moving the fix into aclocal.m4.
I assume PACKAGE_NAME will be moved along with VERSION and PACKAGE?
If I don't hear anything during the day, I'll just commit the below patch.

  Lars J

Index: ChangeLog
===================================================================
RCS file: /cvs/autoconf/ChangeLog,v
retrieving revision 1.1345
diff -u -r1.1345 ChangeLog
--- ChangeLog   2001/04/06 14:35:22     1.1345
+++ ChangeLog   2001/04/09 11:07:38
@@ -1,3 +1,9 @@
+2001-04-09  Lars J. Aas  <address@hidden>
+
+       * Makefile.am: Manual addition of @PACKAGE@ substitution variable
+       needed by dist rules.  Added explanatory comment.
+       Problem reported and comment suggested by Raja R Harinath.  
+
 2001-04-06  Lars J. Aas  <address@hidden>
 
        * Makefile.am: Manual addition of @VERSION@ substitution variable
Index: Makefile.am
===================================================================
RCS file: /cvs/autoconf/Makefile.am,v
retrieving revision 1.43
diff -u -r1.43 Makefile.am
--- Makefile.am 2001/04/06 11:20:04     1.43
+++ Makefile.am 2001/04/09 11:07:38
@@ -31,9 +31,10 @@
 EXTRA_SCRIPTS = autoscan autoupdate
 
 # FIXME: Current Automakes are blind and cannot see inner AC_SUBST,
-# so help it.
+# so help it.  This is because, in this case, 'aclocal' is bypassed.
 PACKAGE_NAME = @PACKAGE_NAME@
 VERSION = @VERSION@
+PACKAGE = @PACKAGE@
 
 # FIXME:
 # s/distpackageDATA/dist_pkgdata_DATA/