[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] add xlc support to depcomp

From: Stefano Lattarini
Subject: Re: [PATCH] add xlc support to depcomp
Date: Mon, 05 Mar 2012 20:08:28 +0100

On 03/05/2012 05:52 PM, Michael wrote:
> Hi Stefano,
> Am 03.03.2012 19:53, schrieb Stefano Lattarini:
>> The patch looks good, is unobtrusive, and is small enough to be applied
>> without requiring you to sign any copyright paper (yay!).  Before applying
>> it, though, I'd like to know if you have run the whole automake testsuite
>> with this patch applied (to the master branch) and with CC and CXX pointing
>> to the XL C/C++ compilers.  Even if doing that is not strictly required for
>> such a patch (as a bug would only affect users of the XL compiler), it
>> would be preferable (and much appreciated) if you did so.
> enclosed are all the logs for running "make check" with and without the
> patch.
Alas, sadly not "all the logs" -- the most important one ('tests/test-suite.log'
created by "make check" itself, and holding the details of the runs of skipped
and failed test) is not present.  But see below.

> With the patch, one test more is passed (remake8b.test). However,
> it looks like there was a change in the master branch between the first
> run with patch and the following run without patch. Should I run it again?
Hmm... that test doesn't even use the C compiler, so your patch shouldn't
affect it anyway [1].  At this point, I'd like to just go ahead and applied
the patch in your name -- speaking of which, would you mind telling us your
full name, so that we can use it for the THANKS addition and for the git
commit's "Author" field?



 [1] Still, if you want to try to reproduce the failure, feel free to do
     so and to open a new report by writing to address@hidden; we'd
     really appreciate that.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]