[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: push parser implemenation

From: Bob Rossi
Subject: Re: push parser implemenation
Date: Thu, 14 Sep 2006 17:16:20 -0400
User-agent: Mutt/1.5.11

On Thu, Sep 14, 2006 at 03:46:17PM -0400, Bob Rossi wrote:
> On Thu, Sep 14, 2006 at 12:44:00PM -0700, Paul Eggert wrote:
> > Bob Rossi <address@hidden> writes:
> > 
> > > Honestly, I don't understand why a pull parser needs this feature.
> > 
> > If nobody knows why it'd be useful then let's just omit it for now.
> > All we need to do is document the fact that the combination of
> > features is not supported.  Someone who actually needs the feature
> > will be a better judge of how it should be implemented.
> OK, thank you. I'm going to incorporate all the changes we've discussed
> so far and post a patch to this list.

Here it is, this diff would have been much smaller if the file 
src/parse-gram.y wasn't re-bisoned.

Also note that push.c is attached separatly. A diff between it and
yacc.c will reveal that they are not that much different.

I've also attached the current version of the benchmark program that
I've been using.

The results of the testsuite and benchmark are below. 


            Rate push-push yacc-pure push-pure yacc-yacc push-yacc
push-push 2.93/s        --      -27%      -27%      -29%      -29%
yacc-pure 4.02/s       37%        --       -0%       -2%       -2%
push-pure 4.04/s       38%        0%        --       -2%       -2%
yacc-yacc 4.12/s       40%        2%        2%        --       -0%
push-yacc 4.12/s       40%        2%        2%        0%        --

Note that there is no time delay between yacc and push skeletons.

Testsuite run with push.c. (ie. cp push.c yacc.c before running):
    90. Calculator %push-parser %locations ( ok
    96. Calculator %push-parser %error-verbose %debug %locations 
        %defines %name-pref

    179 tests were successful.
    2 tests were skipped.

Please let me know what the next steps will be.

Bob Rossi

Attachment: push.diff
Description: Text document

Attachment: push.c
Description: Text Data

Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]