[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils-6.5: yet another C89 problem

From: Jim Meyering
Subject: Re: coreutils-6.5: yet another C89 problem
Date: Tue, 21 Nov 2006 10:15:15 +0100

Michael Deutschmann <address@hidden> wrote:
> Yet again, a new C89-incompatibility has appeared in coreutils (6.5) that
> is not covered by c99-to-c89.diff.  It's different from all I've reported
> before.
> The fix is appended.

Thanks for the patch.  I applied it.
As you can see, I am not very motivated to be
proactive about supporting such ancient compilers.
Is upgrading not an option for you?

        * lib/fts.c (fts_safe_changedir): Move a declaration "up",
        so as to remain compatible with older compilers.
        Patch from Michael Deutschmann.

Index: lib/fts.c
RCS file: /sources/gnulib/gnulib/lib/fts.c,v
retrieving revision 1.27
diff -u -p -r1.27 fts.c
--- lib/fts.c   12 Nov 2006 17:35:39 -0000      1.27
+++ lib/fts.c   21 Nov 2006 09:10:30 -0000
@@ -1645,8 +1645,9 @@ fts_safe_changedir (FTS *sp, FTSENT *p,
               failure when we lack "x" access to the virtual cwd.  */
            if ( ! i_ring_empty (&sp->fts_fd_ring))
+               int parent_fd;
                fd_ring_print (sp, stderr, "pre-pop");
-               int parent_fd = i_ring_pop (&sp->fts_fd_ring);
+               parent_fd = i_ring_pop (&sp->fts_fd_ring);
                is_dotdot = true;
                if (0 <= parent_fd)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]