bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2


From: Ken Brown
Subject: bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2
Date: Fri, 20 Jul 2018 10:27:06 -0400
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 7/20/2018 10:17 AM, Eli Zaretskii wrote:
Cc: address@hidden, address@hidden
From: Ken Brown <address@hidden>
Date: Fri, 20 Jul 2018 09:49:39 -0400

../../master/src/w32cygwinx.c: In function ‘format_string’:
../../master/src/w32cygwinx.c:32:3: warning: function ‘format_string’
might be a candidate for ‘gnu_printf’ format attribute
[-Wsuggest-attribute=format]
     Lisp_Object str = vformat_string (format, args);
     ^~~~~~~~~~~

We do this with vformat_string:

   extern Lisp_Object vformat_string (const char *, va_list)
     ATTRIBUTE_FORMAT_PRINTF (1, 0);

So I guess this new function needs a similar treatment.

Amended patch attached.

Ken

Attachment: 0001-Simplify-w32cygwinx.c-and-pacify-GCC-Bug-32189.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]