[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2

From: Paul Eggert
Subject: bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2
Date: Fri, 20 Jul 2018 14:03:30 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 07/20/2018 12:34 PM, Ken Brown wrote:
Would it make sense to move its definition to eval.c, where vformat_string is defined, and declare it as external in lisp.h?

Sure, if it's needed. In practice, I've found Fformat and Fformat_message to be more useful at the C level (among other things they handle more formats), and suggest using them if they're applicable. But if they're not, we can use format_string elsewhere -- though it would be helpful to note its limitations compared to Fformat_string, in a comment perhaps (you can see some of its limitations in the long comment at the start of doprnt.c, which the format_string comment could refer to).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]