bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43725: 28.0.50; Include feature/native-comp into master


From: Eli Zaretskii
Subject: bug#43725: 28.0.50; Include feature/native-comp into master
Date: Fri, 19 Feb 2021 09:51:51 +0200

> From: Andrea Corallo <akrl@sdf.org>
> Cc: bug-gnu-emacs@gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca,
>         43725@debbugs.gnu.org
> Date: Thu, 18 Feb 2021 20:53:05 +0000
> 
> >> comp.c:1174:22: warning: logical ‘or’ of collectively exhaustive tests is 
> >> always true [-Wlogical-op]
> >>  1174 |   if (val > LONG_MAX || val < LONG_MIN)
> >>       |                      ^~
> >> 
> >> Not sure what's the best way to silence it or if we want to revert to
> >> the previous formulation.
> 
> Hi Eli,
> 
> sorry just to make sure I understand the suggestions:
> 
> > You can either condition that by WIDE_EMACS_INT,
> 
> Put it under #ifdef I guess.
> 
> > or add a comparison > between LONG_MAX and INT_MAX.
> 
> Not sure I understand how you'd write this.

Maybe it will be easier to do something like this instead:

  #if EMACS_INT_MAX > LONG_MAX
    return emit_rvalue_from_unsigned_long_long (...
  #else
    return gcc_jit_context_new_rvalue_from_long (...
  #endif

Does that work well?

Btw, why does the 'long long' variant say "unsigned", while the 'long'
variant doesn't?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]