bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43725: 28.0.50; Include feature/native-comp into master


From: Eli Zaretskii
Subject: bug#43725: 28.0.50; Include feature/native-comp into master
Date: Fri, 19 Feb 2021 15:37:52 +0200

> From: Pip Cet <pipcet@gmail.com>
> Date: Fri, 19 Feb 2021 12:53:43 +0000
> Cc: 43725@debbugs.gnu.org, eliz@gnu.org, larsi@gnus.org, 
>       Stefan Monnier <monnier@iro.umontreal.ca>
> 
> > comp.c:1174:22: warning: logical ‘or’ of collectively exhaustive tests is 
> > always true [-Wlogical-op]
> >  1174 |   if (val > LONG_MAX || val < LONG_MIN)
> >       |                      ^~
> >
> > Not sure what's the best way to silence it or if we want to revert to
> > the previous formulation.
> 
> Maybe it's me, but I had a hard time parsing that warning. IIUC, the
> tests are both trivially false? And oring two trivially false
> conditions shouldn't trigger a warning, should it?

No, I think it tries to say that val is always either greater than
LONG_MAX or smaller than LONG_MIN.

> Sounds like it's GCC that needs to be fixed.

Could be.  But I've given up on GCC's tendency to warn about perfectly
valid programs.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]