bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43725: 28.0.50; Include feature/native-comp into master


From: Eli Zaretskii
Subject: bug#43725: 28.0.50; Include feature/native-comp into master
Date: Fri, 19 Feb 2021 16:59:40 +0200

> From: Andrea Corallo <akrl@sdf.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, 43725@debbugs.gnu.org, larsi@gnus.org,
>         Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Fri, 19 Feb 2021 14:35:43 +0000
> 
> >> > No, I think it tries to say that val is always either greater than
> >> > LONG_MAX or smaller than LONG_MIN.
> >>
> >> Exactly, the warning is about the fact that all the other conditions
> >> will never be evaluated.  The phrasing is admittedly quite cryptic tho.
> >
> > I thought you said this was a setup where the argument _does_ fit a long?
> 
> There we are dispatching if 'val' can be expressed or not with a long.
> 
> 'val' is an EMACS_INT so depending on the configuration it might fit in
> a long by definition, when this happen GCC sees the first condition in
> or as always true etc etc... :)

The condition would be always true if it were written like this:

  if (val >= LONG_MIN && val <= LONG_MAX)

But that wasn't what the code was saying, it was the exact opposite of
this condition.  So I think GCC was actually complaining about the
'else' clause.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]