tar-1.13 and tape_lenght

[Giuseppe Lo Biondo]

Hi!,

It seems that the -L option in tar 1.13 is broken,

The flag argument check:

(xstrtoul (optarg, (char **) 0, 10, &u, "") != LONG_MAX) ;
is (almost) never  true.

--------
This

 case 'L':
        {
          unsigned long u;
          if (xstrtoul (optarg, (char **) 0, 10, &u, "") != LONG_MAX)

            USAGE_ERROR ((0, 0, _("Invalid tape length")));
          clear_tarlong (tape_length_option);
          add_to_tarlong (tape_length_option, u);
          mult_tarlong (tape_length_option, 1024);
          multi_volume_option = 1;
        }
        break;

should be

 case 'L':
        {
          unsigned long u;
          if (xstrtoul (optarg, (char **) 0, 10, &u, "") >= LONG_MAX)

            USAGE_ERROR ((0, 0, _("Invalid tape length")));
          clear_tarlong (tape_length_option);
          add_to_tarlong (tape_length_option, u);
          mult_tarlong (tape_length_option, 1024);
          multi_volume_option = 1;
        }
        break;

(.... or at least this is what is fine for me)

Best Regards,
Giuseppe Lo Biondo