[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] inttostr: simplify by removing unnecessary redundancy
From: |
Paul Eggert |
Subject: |
Re: [PATCH] inttostr: simplify by removing unnecessary redundancy |
Date: |
Fri, 22 Oct 2010 12:47:15 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.14) Gecko/20101006 Thunderbird/3.0.9 |
On 10/22/10 12:23, Jim Meyering wrote:
> anytostr.c:34: error: comparison of unsigned expression < 0 is always
> false [-Wtype-limits]
Hmm, I could have sworn I tested that with -Wtype-limits and it worked
for me, but evidently I messed up (or perhaps I used a compiler that
is not as stupid as GCC :-). Anyway, thanks for catching
that and I reverted the change.
I avoid -Wtype-limits since in my experience it causes more trouble
(harder-to-read and not-always-compiled and therefore buggier code)
than it cures (careless coding errors).
Re: [PATCH] inttostr: simplify by removing unnecessary redundancy, Eric Blake, 2010/10/22