[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] inttostr: simplify by removing unnecessary redundancy

From: Jim Meyering
Subject: Re: [PATCH] inttostr: simplify by removing unnecessary redundancy
Date: Fri, 22 Oct 2010 21:58:54 +0200

Paul Eggert wrote:

> On 10/22/10 12:23, Jim Meyering wrote:
>>     anytostr.c:34: error: comparison of unsigned expression < 0 is always 
>> false [-Wtype-limits]
> Hmm, I could have sworn I tested that with -Wtype-limits and it worked
> for me, but evidently I messed up (or perhaps I used a compiler that
> is not as stupid as GCC :-).  Anyway, thanks for catching
> that and I reverted the change.
> I avoid -Wtype-limits since in my experience it causes more trouble
> (harder-to-read and not-always-compiled and therefore buggier code)
> than it cures (careless coding errors).

Toeing the line in this case is counterproductive.
How about sticking with your improvement and instead
using this pragma in that file?

# pragma GCC diagnostic ignored "-Wtype-limits"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]