[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: system colors

From: Fred Kiefer
Subject: Re: system colors
Date: Tue, 10 Feb 2004 20:37:13 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030821

Rob Burns wrote:
I was experimenting with changing the colors in GNUstep, and found that NSTabView wasn't paying attention to the changes. If I understand things correctly, using drawButton instead of NSDrawButton in the drawRect: method will fix this. The included patch does this.

Also, the gnustep menus currently do not make use of the windowFrameColor default. I think the problem is in the GSTitleView class. The other included patch appears to fix this. The patch only works for menu windows, and not regular windows (if/when GSTitleView is used for regular windows).

If these changes are correct, could someone make the changes in cvs?

And, somewhat related, the background of the icons above the browser in GWorkspace remains dark grey regardless of the color defaults. I haven't been able to find where this gets done.

Sorry to frustrate you, but you choose the wrong classes to start the GUI colour cleanup. I really would like to see this happen, but doing just a few bits in a class doesn't really help much. NSTabView is a horrible beast, as far as drawing is concerned. With your patch the main part, the pane area would be ok. but it would no longer match the tabs themselves, which currently get drawn partly as images and partly as PS code. For the GSTitleView you just did pick out the lines where he colour for the menue title get set, but there are many more places in that file where direct colours get used (and to be honest I did not fully understand the logic of all of them). Why did you choose windowFrameColor as the replacement for black? It defaults to black, but is this really the name with which you expect to change the colour of the menu title? And you also did not change the text colour, that way you may end up drawing white on white.

So, while I am all in favour for your patch, I would like to reject it for the moment to force you to come back with an even better solution.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]