Re: [bug-gtypist] ideas, implementations, patches.

[clutton]

On Thu, 2016-05-19 at 20:44 +0100, Tim Marston wrote:
> Hi,
> 
> On Thu, May 19, 2016 at 10:38:22PM +0300, clutton wrote:
> > 
> > On Sat, 2016-05-14 at 16:21 +0200, Felix Natter wrote:
> > > 
> > > A gentoo user complained that if you disable Native Language
> > > Support (--disable-nls), then not only translation support
> > > is disabled, but UTF8 support is broken, too. See [2].
> > it's probably here gtypist.c:
> > 
> > #if defined(ENABLE_NLS) && defined(LC_ALL)
> >   setlocale (LC_ALL, "");
> > 
> > Moving setlocale one line up here should help, since as I
> > understand we
> > always need output for wide chars, with or without NLS.
> I can confirm that we do always use utf-8, with or without NLS.
> 
> Kind regards,

Then setlocale (LC_ALL, ""); must be called regardless of NLS choice.
Felix could you take a look? Because on my BSD it refuses building
without NLS.

Which is not surprise, because code has _ mapping everywhere, it looks
like NLS support switch wasn't finished yet. It works on Linux because
Linux has gettext as a part of other libs, I guess. In my view fixing
nls is not so important though :)

signature.asc
Description: This is a digitally signed message part