[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH hurd] build: Drop unused/unsubstituted config variables

From: David Michael
Subject: [PATCH hurd] build: Drop unused/unsubstituted config variables
Date: Sun, 25 Jun 2017 23:24:52 -0700

* config.make.in (HAVE_BLKID, HAVE_DAEMON): Drop variable.


Here is a cleanup of two lines that make config.make look like it has
configure mistakes.

I was really checking around for why "make install" is now broken with
X11 enabled.  It looks like a4f5b76390f1c7b377efbac488b57fa6756da80a is
just incorrect.  That commit prepends $(prefix) to the target for xkb
file names, not directories, and only one of the three files to be

Even if it added $(prefix) consistently to XKB_BASE, the value of
XKB_BASE is either from the xkeyboard-config.pc file which is the
system's configured directory (so it seems wrong to add another prefix
to it), or it defaults to "$datadir/X11/xkb" where "$datadir" should
already be configured with "$prefix" included.

Should a4f5b76390f1c7b377efbac488b57fa6756da80a just be reverted?  If
that change is correct, can someone give me an example configuration
where it can work?



 config.make.in | 2 --
 1 file changed, 2 deletions(-)

diff --git a/config.make.in b/config.make.in
index 4f2f1fe..dfbf0c1 100644
--- a/config.make.in
+++ b/config.make.in
@@ -80,7 +80,6 @@ XKB_BASE = @XKB_BASE@
 # How to compile and link against libdaemon.
 libdaemon_CFLAGS = @libdaemon_CFLAGS@
 libdaemon_LIBS = @libdaemon_LIBS@
@@ -91,7 +90,6 @@ HAVE_LIBBZ2 = @HAVE_LIBBZ2@
 # How to compile and link against libblkid.
 libblkid_CFLAGS = @libblkid_CFLAGS@
 libblkid_LIBS = @libblkid_LIBS@

reply via email to

[Prev in Thread] Current Thread [Next in Thread]