[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Segmentation fault with current development version of wg

From: Giuseppe Scrivano
Subject: Re: [Bug-wget] Segmentation fault with current development version of wget
Date: Sun, 05 May 2013 02:18:02 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Hi Darshit,

Darshit Shah <address@hidden> writes:

> The patch supplied by you adding cmd_uppercase_String seems to break
> the header generation since (*q++) causes the pointer to increment
> before the c_toupper() method returns. 
> We should instead increment it only after the statement successfully
> returns.
> I have also converted the loop to a for loop to reduce number of
> lines. 

while I agree that your patch makes the code more readable and it is
good to apply it, I don't see how the previous version was broken.  What
compiler have you used?

> One issue I see with the latest commit that suspends the method on
> redirection is when using HEAD. 
> When I use --method=HEAD, I have no intentions of it getting converted
> to GET upon redirection. In fact, I don't think wget should even
> follow the redirection when opt.method is "HEAD".

Good catch!  Maybe we should handle --method=HEAD as opt.spider?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]