Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor

[John Ericson]

Here are the last 3 patches, revised

Yes the * is probably just a cut and paste artifact. I suppose it is 
harmless and could hint to the human what the expected behavior, but for 
simplicity I just removed it. The crx- * test I deleted from the first 
patch too. That leaves the 1st patch working properly.

The 2nd patch is exactly as before. It still breaks things, but that is 
intentional, with the 3rd patch fixing the breakage and the crx test 
instead. I could have combined them, but I suspect they'll be easier to 
read separately so I kept them separate. If you want to apply them 
together that is fine with me.

Thanks,

John


On 08/20/18 00:34, Ben Elliston wrote:
> On Tue, Aug 14, 2018 at 01:53:37PM -0400, John Ericson wrote:
>
> > Message-Id: <address@hidden>
> > From: John Ericson <address@hidden>
> > Date: Tue, 14 Aug 2018 13:25:58 -0400
> > Subject: [PATCH 1/2]     * testsuite/config-sub.data: Add legacy test cases
> > To: address@hidden
> This is a bit weird:
>
> > @@ -140,8 +142,13 @@ dec3100                                            
> > mips-dec-ultrix4.2
> >   decstation                                    mips-dec-ultrix4.2
> >   decstation-3100                                       mips-dec-ultrix4.2
> >   decstatn                                      mips-dec-ultrix4.2
> > +decsystem10*                                   pdp10-dec-tops10
> > +dec10*                                         pdp10-dec-tops10
> > +decsystem20*                                   pdp10-dec-tops20
> > +dec20*                                         pdp10-dec-tops20
> >   dicos                                         i686-pc-dicos
> Why are you adding test cases with asterisks in them?  Looks like too
> much copying and pasting?
>
> Also, the revised testsuite does not pass:
>
> Invalid configuration `crx-unknown-elf': machine `crx-unknown' not recognized
> FAIL: crx-unknown-elf -> , but crx-unknown-elf should map to itself
>
> Please remove the failing tests until you submit a patch that fixes
> the problem (and the test case can accompany that patch).
>
> Thanks,
> Ben

0001-testsuite-config-sub.data-Add-legacy-test-cases.patch
Description: Text document

0002-config.sub-Move-the-big-patterns-to-the-bottom.patch
Description: Text document

0003-Tenative-fixes-to-issues-arriving-from-previous-comm.patch
Description: Text document