Re: [PATCH] tests: add missing sys/types.h for ls speed-up test

[Jim Meyering]

Jérémy Compostella wrote:

> All,
>
> I have the following error message in getxattr-speedup.log:
>
>   FAIL: ls/getxattr-speedup (exit: 99)
>   ====================================
>
>   k.c:13: error: expected '=', ',', ';', 'asm' or '__attribute__' before 
> 'incr'
>   k.c:14: error: expected '=', ',', ';', 'asm' or '__attribute__'
> before 'getxattr'
>   k.c:16: error: expected '=', ',', ';', 'asm' or '__attribute__'
> before 'lgetxattr'
>   getxattr-speedup: set-up failure: failed to compile with -fPIC
>
> I added the missing sys/types.h include in ls/getxattr-speedup.
> See the corresponding patch in attachment.

Hi Jérémy,

Thank you for the report and the patch.
Please tell us what type/version of compiler/system you're using.
It's good to include that information, especially since ssize_t
is supposed to be defined via stdio.h.  Then it is clear that this
change is working around a problem with non-conforming systems.


>>From 409e1c27fa056f52583a002a9f28f9c45469165a Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Compostella?= <address@hidden>
> Date: Sun, 19 Feb 2012 15:38:15 +0100
> Subject: [PATCH] tests: add missing sys/types.h for ls speed-up test
>
> * tests/ls/getxattr-speedup: add missing sys/types.h header include.
> ---
>  tests/ls/getxattr-speedup |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tests/ls/getxattr-speedup b/tests/ls/getxattr-speedup
> index 2b7a1f3..a35dd69 100755
> --- a/tests/ls/getxattr-speedup
> +++ b/tests/ls/getxattr-speedup
> @@ -28,6 +28,7 @@ print_ver_ ls
>  cat > k.c <<'EOF' || framework_failure_
>  #include <errno.h>
>  #include <stdio.h>
> +#include <sys/types.h>
>
>  static unsigned long int n_calls;