[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RFE: hash-type in sum utils

From: Ondrej Oprala
Subject: Re: RFE: hash-type in sum utils
Date: Thu, 26 Jul 2012 10:06:38 -0400 (EDT)

Sorry but I cant seem to create a filename that would cause md5sum --tag  to
output escaping different from the BSD's md5. Could you be more specific on the 
BSD escaping problem, please?
Also thanks for the formatting patch.

----- Original Message -----
From: "Pádraig Brady" <address@hidden>
To: "Ondrej Oprala" <address@hidden>
Cc: address@hidden, "D Yu Bolkhovityanov" <address@hidden>
Sent: Thursday, July 26, 2012 2:47:15 PM
Subject: Re: RFE: hash-type in sum utils

On 07/26/2012 12:59 PM, Ondrej Oprala wrote:
> Ok, here is my patch proposition. I hope it's satisfactory.

Thanks for doing that!
I've attached a mainly formatting cleanup patch.

BTW be careful with strlen() in a for loop test.
That may not be optimized by the compiler,
especially when the passed string is not const or restrict.

The main logic outstanding is to escape the filename
in a BSD compat fashion.
I can have a look at that if you want, but not today.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]