[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] maint: don't reset PATH in out commit-msg git hook

From: Pádraig Brady
Subject: Re: [PATCH 1/2] maint: don't reset PATH in out commit-msg git hook
Date: Fri, 15 Feb 2013 14:56:59 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

On 02/15/2013 01:39 PM, Stefano Lattarini wrote:
I have a custom 'editor' script in ~/bin, and a system-provided
'editor' program in /usr/bin (on Debian, this is a link set up the
"debian alternatives" subsystem).  My '$EDITOR' and '$GIT_EDITOR'
variables are set simply to 'editor' (no absolute path), which I
expect should point to my 'editor' script, since ~/bin precedes
/usr/bin in my PATH definition. But the 'commit-msg' hook used in
coreutils unconditionally resets its PATH to '/bin:/usr/bin', which
causes it to call the "wrong" editor (the one in /usr/bin, not the
one in ~/bin) when it makes me update a botched commit message.

* scripts/git-hooks: Don't reset $ENV{PATH} to '/bin:/usr/bin'.
  scripts/git-hooks/commit-msg | 1 -
  1 file changed, 1 deletion(-)

diff --git a/scripts/git-hooks/commit-msg b/scripts/git-hooks/commit-msg
index 3e91e8e..7a11489 100755
--- a/scripts/git-hooks/commit-msg
+++ b/scripts/git-hooks/commit-msg
@@ -7,7 +7,6 @@ use warnings;
  (my $ME = $0) =~ s|.*/||;

  my $editor = $ENV{EDITOR} || 'vi';
-$ENV{PATH} = '/bin:/usr/bin';

  # Keywords allowed before the colon on the first line of a commit message:
  # program names and a few general category names.

I'll wait for Jim's input on why he explicitly set a restrictive $PATH
It looks good to me anyway.  I'll fix up the "out" typo in the commit
summary, when applying.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]