[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] maint: choose editor for our commit-msg git hook the sam

From: Pádraig Brady
Subject: Re: [PATCH 2/2] maint: choose editor for our commit-msg git hook the same way git does
Date: Sat, 16 Feb 2013 11:51:22 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

On 02/16/2013 10:31 AM, Bernhard Voelker wrote:
Hi Stefano,

On 02/16/2013 07:16 AM, Stefano Lattarini wrote:
Hi Bernhard.

On 02/15/2013 04:54 PM, Bernhard Voelker wrote:
Strange, when I provoke a 2nd re_edit() by giving a bad commit
message, then "Vim" is used as $editor instead my $GIT_EDITOR
(which has been successfully used in the first place).

Have you re-run ./bootstrap to cause the updated hook to be
installed in .git/hooks?

I only updated .git/hooks/commit-msg without any "make" or
"bootstrap". And this is what I did:

   In an xterm:

   $ ls >> src/df.c
   $ git add src/df.c
   $ git commit

   Then my $GIT_EDITOR opens as expected.

   I enter "hello world." as commit message and quit.

   ==> Then, vi is started in that xterm with the complaint
       line at the top to fix the commit message.

After that, my xterm is totally messed up and only "reset"

Yes I see that too, though the messed up xterm
was an issue before this patch.
commit-msg also needs to be updated to allow
easily aborting the commit. A common way to do
that is to write an empty commit message.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]