coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cp,mv,install: avoid opening destination non directories


From: Paul Eggert
Subject: Re: [PATCH] cp,mv,install: avoid opening destination non directories
Date: Sat, 9 Apr 2022 13:01:16 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

On 4/9/22 11:38, Pádraig Brady wrote:

The attached uses an extra stat() to avoid this hang,
but only on these older systems without O_DIRECTORY.

Thanks, good catch.

I think you can simplify the system.h patch a bit, as there's no need for 'err' in this new code. Also, the "try an open a fifo" should be "try to open a fifo" or "try and open a fifo". Something like the attached patch, perhaps?

Attachment: coreutils-system.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]