Re: [PATCH] cp,mv,install: avoid opening destination non directories

[Pádraig Brady]

On 09/04/2022 21:01, Paul Eggert wrote:
> On 4/9/22 11:38, Pádraig Brady wrote:
>
> > The attached uses an extra stat() to avoid this hang,
> > but only on these older systems without O_DIRECTORY.
>
> Thanks, good catch.
>
> I think you can simplify the system.h patch a bit, as there's no need
> for 'err' in this new code. Also, the "try an open a fifo" should be
> "try to open a fifo" or "try and open a fifo". Something like the
> attached patch, perhaps?

Pushed with that simplification, and added a NEWS entry.

thanks for the review!
Pádraig