[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Please check-in Belanger's Calc patches

From: Stefan
Subject: Re: Please check-in Belanger's Calc patches
Date: 21 Jul 2004 10:07:05 -0400
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

>       calc-invocation-macro, calc-show-banner): Define these as part of
>           `calc-mode-var-list's initialization, instead of using defvar.

Not defining those vars with defvar means that the byte-compiler doesn't
get the info it wants.  It doesn't necessarily lead to wrong code, but it's
very bad coding style and can prevent optimizations (which are admittedly
not currently implemented).  It also leads to lots and lots of spurious
warnings during byte-compilation.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]