Re: Please check-in Belanger's Calc patches

[Stefan Monnier]

>> [...]
>>> calc-invocation-macro, calc-show-banner): Define these as part of
>>> `calc-mode-var-list's initialization, instead of using defvar.
>> 
>> Not defining those vars with defvar means that the byte-compiler doesn't
>> get the info it wants.  It doesn't necessarily lead to wrong code, but it's
>> very bad coding style and can prevent optimizations (which are admittedly
>> not currently implemented).  It also leads to lots and lots of spurious
>> warnings during byte-compilation.

> Calc stores those variables in calc-mode-var-list so that functions
> (which store and reset those variables) can easily access them.  
> There are about four functions which do this.  If these variables are
> set individually by defvar, then the store-reset functions would have
> to be redone.  Restoring calc-mode-var-list is easier, but redoing the
> functions is doable, no doubt.

But as a short-term fix, can't they be both defvar'd and listed in
calc-mode-var-list?


        Stefan