[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reviewing changes

From: Stefan Monnier
Subject: Re: Reviewing changes
Date: Wed, 19 Nov 2008 21:13:33 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

> I thought log-accum.pl was the answer to this, in CVS-land?  (It's been

By "thought" I guess you meant "hoped"? ;-)

> We don't need to have a fully-specified, formal review system to benefit
> from more frequent informal reviews.  Many projects get by on just
> having the diff+log appear in the same email -- then the review "system"
> is simply people reading their email.  It works quite well.

Agreed.  Improving the diff&commit messages is just a good thing.  If it
encourages reviews, even better.

> If there's no agreement to have a review process, I can simply ignore
> your review.

Of course.  Would that be a problem?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]