[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reviewing changes

From: Eli Zaretskii
Subject: Re: Reviewing changes
Date: Fri, 21 Nov 2008 17:14:54 +0200

> From: Stefan Monnier <address@hidden>
> Cc: address@hidden,  address@hidden,  address@hidden
> Date: Fri, 21 Nov 2008 09:32:28 -0500
> >> So you object to naming them "code reviews"?  That's OK, let's call them
> >> "random comments", then.
> >> I just can't see how encouraging such random comments can hurt.
> > I didn't say it will hurt.  I said it won't help us make the code
> > quality better, which I assumed what this was all about.  Sounds like
> > my assumption was wrong.
> No, this was all about asking to change the format of the email sent to
> emacs-diffs and emacs-commit so that they'd contain both the changelog
> and the diffs (hopefully of all the files modified by the given
> commit) together.
> Karl mentioned he'd prefer it, and also added that it would make
> reviewing easier.

Karl _asked_ for it, and he said he was asking _because_ it will make
reviewing easier.

> Your argumentation seemed to say that you disagreed with such a change
> specifically because it would make people start to do such
> pseudo-reviewing which is worse than not doing reviewing at all.

I don't think I wrote anything that could be read like this.  In
particular, I don't think I ever said I disagreed with the change.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]