[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: md5 broken?

From: Eli Zaretskii
Subject: Re: md5 broken?
Date: Sat, 28 May 2011 17:10:58 +0300

> From: Jim Meyering <address@hidden>
> Cc: address@hidden,  address@hidden,  address@hidden
> Date: Sat, 28 May 2011 15:32:50 +0200
> Eli Zaretskii wrote:
> >> From: Jim Meyering <address@hidden>
> >> Date: Sat, 28 May 2011 14:23:43 +0200
> >> Cc: Paul Eggert <address@hidden>, address@hidden
> >>
> >> +static inline unsigned char to_uchar (char ch) { return ch; }
> >
> > I think this should use "INLINE", upper-cased, rather than "inline",
> > for those compilers that don't support the `inline' keyword.  See
> > src/config.in.
> Using "inline" is fine because of the configure-time test that
> defines "inline" to nothing when it is not supported:

You obviously assume that every supported build runs the `configure'
script.  But that is false, of course.

> There is one other use already:
>     lread.c:2256:static inline int
> There are far more uses of INLINE:
>     $ git grep -w INLINE|grep -cw INLINE
>     144

Yes.  I believe Emacs used "INLINE" for far longer than "inline".

> Is there any reason not to replace all uses of INLINE with "inline"
> and to remove the following from configure.in?  I see no use of
> "extern INLINE" anywhere in emacs:

I don't know enough about the "extern INLINE" issue to answer that,
sorry.  But if it is decided to switch to "inline" everywhere, we
should make sure it works with all the supported builds, not only with
those that run `configure'.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]